[PATCH] ASoC: rockchip-i2s: add rockchip-max98090 driver support

[Jianqun]

This patch is to add support for rockchip board with max98090 codec.
It also needs sound node in dt file.

Tested on rockchip board based on rk3288.

Signed-off-by: Jianqun <***@rock-chips.com>
---
sound/soc/rockchip/Kconfig | 13 +++++++++++++
1 file changed, 13 insertions(+)

diff --git a/sound/soc/rockchip/Kconfig b/sound/soc/rockchip/Kconfig
index 78fc159..482cbba 100644
--- a/sound/soc/rockchip/Kconfig
+++ b/sound/soc/rockchip/Kconfig
@@ -9,3 +9,16 @@ config SND_SOC_ROCKCHIP

config SND_SOC_ROCKCHIP_I2S
tristate
+ depends on CLKDEV_LOOKUP && SND_SOC_ROCKCHIP
+ help
+ Say Y or M if you want to add support for I2S driver for Rockchip
+ I2S device.
+
+config SND_SOC_ROCKCHIP_MAX98090
+ tristate "ASoC support Rockchip board with max98090"
+ depends on I2C && GPIOLIB
+ select SND_SOC_ROCKCHIP_I2S
+ select SND_SOC_MAX98090
+ help
+ Say Y or M here if you want to add support for Rockchio board using
+ a max98090 codec.

[Lars-Peter Clausen]

Post by Jianqun
This patch is to add support for rockchip board with max98090 codec.
It also needs sound node in dt file.
Tested on rockchip board based on rk3288.
---
sound/soc/rockchip/Kconfig | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/sound/soc/rockchip/Kconfig b/sound/soc/rockchip/Kconfig
index 78fc159..482cbba 100644
--- a/sound/soc/rockchip/Kconfig
+++ b/sound/soc/rockchip/Kconfig
@@ -9,3 +9,16 @@ config SND_SOC_ROCKCHIP
config SND_SOC_ROCKCHIP_I2S
tristate
+ depends on CLKDEV_LOOKUP && SND_SOC_ROCKCHIP
+ help
+ Say Y or M if you want to add support for I2S driver for Rockchip
+ I2S device.
+
+config SND_SOC_ROCKCHIP_MAX98090
+ tristate "ASoC support Rockchip board with max98090"
+ depends on I2C && GPIOLIB
+ select SND_SOC_ROCKCHIP_I2S
+ select SND_SOC_MAX98090
+ help
+ Say Y or M here if you want to add support for Rockchio board using
+ a max98090 codec.

Just make the max98090 driver directly selectable. That's what we typically
do for DT based designs.

- Lars

[Jianqun]

This patch is to add support for rockchip board with max98090 codec.
It also needs sound node in dt file.

Tested on rockchip board based on rk3288.

Signed-off-by: Jianqun <***@rock-chips.com>
---
change since v1:
-Just make the max98090 driver directly selectable, suggested by Lars

sound/soc/rockchip/Kconfig | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/sound/soc/rockchip/Kconfig b/sound/soc/rockchip/Kconfig
index 78fc159..230b0e9 100644
--- a/sound/soc/rockchip/Kconfig
+++ b/sound/soc/rockchip/Kconfig
@@ -9,3 +9,15 @@ config SND_SOC_ROCKCHIP

config SND_SOC_ROCKCHIP_I2S
tristate
+ depends on CLKDEV_LOOKUP && SND_SOC_ROCKCHIP
+ help
+ Say Y or M if you want to add support for I2S driver for Rockchip
+ I2S device.
+
+config SND_SOC_MAX98090
+ tristate "ASoC support max98090 device driver"
+ depends on I2C && GPIOLIB
+ select SND_SOC_ROCKCHIP_I2S
+ help
+ Say Y or M here if you want to add support for Rockchio board using
+ a max98090 codec.

[Jianqun]

Add SND_SOC_MAX98090 to Kconfig of rockchip ASoC, to support
rockchip board using a max98090 codec.

Tested on rockchip board based on rk3288.

Signed-off-by: Jianqun <***@rock-chips.com>
---
changes since v1:
--make the max98090 driver directly selectable, suggested by Lars

changes since v2:
--modify tristate infomation for SND_SOC_ROCKCHIP
--make SND_SOC_MAX98090 not depends on SND_SOC_ROCKCHIP

sound/soc/rockchip/Kconfig | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/sound/soc/rockchip/Kconfig b/sound/soc/rockchip/Kconfig
index 78fc159..236500e 100644
--- a/sound/soc/rockchip/Kconfig
+++ b/sound/soc/rockchip/Kconfig
@@ -1,5 +1,5 @@
config SND_SOC_ROCKCHIP
- tristate "ASoC support for Rockchip"
+ tristate "SoC Audio for the Rockchip System-on-Chip"
depends on COMPILE_TEST || ARCH_ROCKCHIP
select SND_SOC_GENERIC_DMAENGINE_PCM
help
@@ -8,4 +8,14 @@ config SND_SOC_ROCKCHIP
select the audio interfaces to support below.

config SND_SOC_ROCKCHIP_I2S
- tristate
+ tristate "ASoC support for Rockchip I2S driver"
+ depends on CLKDEV_LOOKUP && SND_SOC_ROCKCHIP
+ help
+ Say Y or M if you want to add support for I2S driver for Rockchip
+ I2S device.
+
+config SND_SOC_MAX98090
+ tristate "ASoC support for max98090 driver"
+ depends on I2C && GPIOLIB
+ help
+ Say Y or M here if you want to add support for max98090 codec.

[Mark Brown]

Post by Jianqun
+config SND_SOC_MAX98090
+ tristate "ASoC support for max98090 driver"
+ depends on I2C && GPIOLIB
+ help
+ Say Y or M here if you want to add support for max98090 codec.

No, you're missing what Lars was saying here - there's already a Kconfig
symbol for the CODEC in the codecs directory, you should add the help
text to that in order to allow the user to enable it. Do this in a
separate patch to making your I2S driver selectable since it's not
directly related code wise.

Please also drop the "ASoC" -> "SoC audio" transition or at least make
it a separate patch.