Discussion:
[PATCH] ASoC: Fix snd_soc_{new, free}_ac97_codec() locking removal
Lars-Peter Clausen
2014-09-23 02:15:48 UTC
Permalink
Commit e3f205a72c45 ("ASoC: Remove locking in
snd_soc_{new,free}_ac97_codec()") overlooked a unlock on one of the error
paths.

Fixes: e3f205a72c45 ("ASoC: Remove locking in snd_soc_{new,free}_ac97_codec()")
Signed-off-by: Lars-Peter Clausen <***@metafoo.de>
---
sound/soc/soc-core.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index f7e4ede..5b88fde 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1967,7 +1967,6 @@ int snd_soc_new_ac97_codec(struct snd_soc_codec *codec,
if (codec->ac97->bus == NULL) {
kfree(codec->ac97);
codec->ac97 = NULL;
- mutex_unlock(&codec->mutex);
return -ENOMEM;
}
--
1.8.0
Mark Brown
2014-09-23 13:45:28 UTC
Permalink
Post by Lars-Peter Clausen
Commit e3f205a72c45 ("ASoC: Remove locking in
snd_soc_{new,free}_ac97_codec()") overlooked a unlock on one of the error
paths.
Applied, thanks.

Loading...