Discussion:
[PATCH] ASoC: rt5677: fix warnings when kernel compiled without GPIOLIB support
Anatol Pomozov
2014-10-15 16:30:49 UTC
Permalink
Signed-off-by: Anatol Pomozov <***@gmail.com>
---
sound/soc/codecs/rt5677.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
index d1fc9a1..2f0d19f 100644
--- a/sound/soc/codecs/rt5677.c
+++ b/sound/soc/codecs/rt5677.c
@@ -3686,6 +3686,11 @@ static void rt5677_free_gpio(struct i2c_client *i2c)
gpiochip_remove(&rt5677->gpio_chip);
}
#else
+static void rt5677_gpio_config(struct rt5677_priv *rt5677, unsigned offset,
+ int value)
+{
+}
+
static void rt5677_init_gpio(struct i2c_client *i2c)
{
}
--
2.1.0.rc2.206.gedb03e5
Mark Brown
2014-10-16 07:43:51 UTC
Permalink
This doesn't apply against current code, please check and resend.
Anatol Pomozov
2014-10-16 16:34:15 UTC
Permalink
Hi
Post by Mark Brown
This doesn't apply against current code, please check and resend.
Ok, I will rebase it on top of topic/rt5677 branch.
Anatol Pomozov
2014-10-16 16:40:58 UTC
Permalink
Signed-off-by: Anatol Pomozov <***@gmail.com>
---
sound/soc/codecs/rt5677.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
index 3b63772..f6df276 100644
--- a/sound/soc/codecs/rt5677.c
+++ b/sound/soc/codecs/rt5677.c
@@ -3649,6 +3649,11 @@ static void rt5677_free_gpio(struct i2c_client *i2c)
dev_err(&i2c->dev, "Failed to remove GPIOs: %d\n", ret);
}
#else
+static void rt5677_gpio_config(struct rt5677_priv *rt5677, unsigned offset,
+ int value)
+{
+}
+
static void rt5677_init_gpio(struct i2c_client *i2c)
{
}
--
2.1.0.rc2.206.gedb03e5
Mark Brown
2014-10-17 09:48:38 UTC
Permalink
Applied, with a fixed subject - this isn't just a warning, it's a build
failure.
Anatol Pomozov
2014-10-17 13:06:53 UTC
Permalink
Hi
Post by Mark Brown
Applied, with a fixed subject - this isn't just a warning, it's a build
failure.
Thanks!

Loading...