Discussion:
[PATCH] ASoC: rt286: Fix compilation warning for !PM
Thierry Reding
2014-10-02 07:27:03 UTC
Permalink
From: Thierry Reding <***@nvidia.com>

The rt286_index_sync() function is only called in the resume path. If PM
is disabled it becomes unused and shouldn't be built either.

Signed-off-by: Thierry Reding <***@nvidia.com>
---
sound/soc/codecs/rt286.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/sound/soc/codecs/rt286.c b/sound/soc/codecs/rt286.c
index b86b426f159d..4aa555cbcca8 100644
--- a/sound/soc/codecs/rt286.c
+++ b/sound/soc/codecs/rt286.c
@@ -269,6 +269,7 @@ static int rt286_hw_read(void *context, unsigned int reg, unsigned int *value)
return 0;
}

+#ifdef CONFIG_PM
static void rt286_index_sync(struct snd_soc_codec *codec)
{
struct rt286_priv *rt286 = snd_soc_codec_get_drvdata(codec);
@@ -279,6 +280,7 @@ static void rt286_index_sync(struct snd_soc_codec *codec)
rt286->index_cache[i].def);
}
}
+#endif

static int rt286_support_power_controls[] = {
RT286_DAC_OUT1,
--
2.1.0
Mark Brown
2014-10-02 10:53:25 UTC
Permalink
Post by Thierry Reding
The rt286_index_sync() function is only called in the resume path. If PM
is disabled it becomes unused and shouldn't be built either.
Applied, thanks.

Loading...