Discussion:
[PATCH 0/2] ASoC: Intel: Add missing build dependencies
Ricardo Neri
2014-10-17 01:22:00 UTC
Permalink
The Broadwell and Haswell machines utilize the RT286 and RT5640 codecs,
respectively. To communicate with the codecs, the machine utilizes the
Designware I2C platform adapter. Hence, such adapter should be present
in order to probe the codec drivers correctly. This short patch series
fixes the missing dependency.

Thanks and BR,
Ricardo

Ricardo Neri (2):
ASoC: Intel: Add new dependency for Broadwell machine
ASoC: Intel: Add new dependency for Haswell machine

sound/soc/intel/Kconfig | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
--
1.9.1
Ricardo Neri
2014-10-17 01:22:01 UTC
Permalink
I2C support for the RT286 codec is provided through the Designware I2C
platform adapter in this machine. Thus, the adapter driver must be present.

Signed-off-by: Ricardo Neri <ricardo.neri-***@linux.intel.com>
---
sound/soc/intel/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index f5b4a9c7..83d5ed1 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -61,7 +61,8 @@ config SND_SOC_INTEL_BYT_MAX98090_MACH

config SND_SOC_INTEL_BROADWELL_MACH
tristate "ASoC Audio DSP support for Intel Broadwell Wildcatpoint"
- depends on SND_SOC_INTEL_SST && X86_INTEL_LPSS && DW_DMAC
+ depends on SND_SOC_INTEL_SST && X86_INTEL_LPSS && DW_DMAC && \\
+ I2C_DESIGNWARE_PLATFORM
select SND_SOC_INTEL_HASWELL
select SND_COMPRESS_OFFLOAD
select SND_SOC_RT286
--
1.9.1
Ricardo Neri
2014-10-17 01:22:02 UTC
Permalink
I2C support for the RT5640 codec is provided through the Designware
I2C platform adapter in this machine. Thus, the driver must be present.

Signed-off-by: Ricardo Neri <ricardo.neri-***@linux.intel.com>
---
sound/soc/intel/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index 83d5ed1..ac03e69 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -32,7 +32,8 @@ config SND_SOC_INTEL_BAYTRAIL

config SND_SOC_INTEL_HASWELL_MACH
tristate "ASoC Audio DSP support for Intel Haswell Lynxpoint"
- depends on SND_SOC_INTEL_SST && X86_INTEL_LPSS && I2C
+ depends on SND_SOC_INTEL_SST && X86_INTEL_LPSS && I2C && \\
+ I2C_DESIGNWARE_PLATFORM
select SND_SOC_INTEL_HASWELL
select SND_SOC_RT5640
help
--
1.9.1
Mark Brown
2014-10-17 12:28:09 UTC
Permalink
Post by Ricardo Neri
The Broadwell and Haswell machines utilize the RT286 and RT5640 codecs,
respectively. To communicate with the codecs, the machine utilizes the
Designware I2C platform adapter. Hence, such adapter should be present
in order to probe the codec drivers correctly. This short patch series
fixes the missing dependency.
Applied both, thanks.

Loading...