[PATCH 6/8] coverity fix in alsa-libs

[Takashi Iwai]

At Thu, 18 Sep 2014 11:29:51 +0000 (GMT),

Hi,
Bug Type : If lib is NULL return error to avoid strlen of NULL string
File changed : simple_abst.c
PFA patch6
Thanks
Renu Tyagi
----------------------------------------------------------------------------------------
From 052755ef6fec398f4e49bd31e9e60fe42a14ba53 Mon Sep 17 00:00:00 2001
Date: Thu, 18 Sep 2014 16:41:43 +0530
Subject: [PATCH 6/8] [simple_abst] : If lib is NULL return error to avoid strlen of NULL string.
---
src/mixer/simple_abst.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/mixer/simple_abst.c b/src/mixer/simple_abst.c
index 9e9aaf5..67330c2 100644
--- a/src/mixer/simple_abst.c
+++ b/src/mixer/simple_abst.c
@@ -71,6 +71,8 @@ static int try_open(snd_mixer_class_t *class, const char *lib)
int err = 0;
path = getenv("ALSA_MIXER_SIMPLE_MODULES");
+ if (!lib)
+ return -ENXIO;

This should be put before getenv() call.
Please fix and resubmit?


Takashi

if (!path)
path = SO_PATH;
xlib = malloc(strlen(lib) + strlen(path) + 1 + 1);
--
1.7.1

[Takashi Iwai]

At Fri, 19 Sep 2014 04:56:12 +0000 (GMT),

From dc9aaa5d6d7a368dc34e1cbdf3fb79670eba1870 Mon Sep 17 00:00:00 2001
Date: Fri, 19 Sep 2014 10:17:28 +0530
Subject: [PATCH] [simple_abst] : adding null check for lib

These are superfluous, but I don't care.

Instead of hanging under the previous thread, could you resubmit your
whole series again (after fixing the issues I suggested -- patch
splitting, subject / changelog reformatting, etc). I have no idea
which one to be taken any longer.


thanks,

Takashi