Discussion:
[PATCH 1/11] mixer : fixed double free
Takashi Iwai
2014-09-22 07:13:41 UTC
Permalink
At Fri, 19 Sep 2014 10:21:10 +0000 (GMT),
Hi,
Ignore previous patches. Resubmiting patch series.
------------------------------------------------------------------------
Signed-off-by: renu tyagi
The mail address has to be provided in the sign-off line together with
your name. And usually, it's "Renu Tyagi", not "renu tyagi". If you
prefer the latter form, I can take it so, though.

Also, the patch series should be shown like "01/11", not "1/11", to
align with the rest.

You may try git-send-email for submitting a series of patches. This
will do most of things right.


thanks,

Takashi
---
src/mixer/mixer.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/src/mixer/mixer.c b/src/mixer/mixer.c
index 56e023d..eee9875 100644
--- a/src/mixer/mixer.c
+++ b/src/mixer/mixer.c
@@ -204,10 +204,8 @@ int snd_mixer_attach(snd_mixer_t *mixer, const char *name)
if (err < 0)
return err;
err = snd_mixer_attach_hctl(mixer, hctl);
- if (err < 0) {
- snd_hctl_close(hctl);
+ if (err < 0)
return err;
- }
return 0;
}
--
1.7.1
[2 patch_1.patch <application/octet-stream (base64)>]
Loading...